Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid circular cimports in _lib/cpp/reduce.pxd #14125

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Avoid circular cimports in _lib/cpp/reduce.pxd #14125

merged 1 commit into from
Sep 20, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 19, 2023

Description

This Cython modules contains some cimports from higher-level modules than it should, which introduces the possibility for circular import issues. Also it contains an unused import of DeviceScalar that can cause similar issues.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. Cython non-breaking Non-breaking change labels Sep 19, 2023
@vyasr vyasr requested a review from a team as a code owner September 19, 2023 00:40
@vyasr vyasr self-assigned this Sep 19, 2023
wence-
wence- approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vyasr
Copy link
Contributor Author

vyasr commented Sep 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 63d197f into rapidsai:branch-23.10 Sep 20, 2023
56 checks passed
@vyasr vyasr deleted the fix/reduce_cimports branch February 15, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @wence-