Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream parameter to external dict APIs #14115

Merged

Conversation

SurajAralihalli
Copy link
Contributor

@SurajAralihalli SurajAralihalli commented Sep 17, 2023

Description

This PR adds stream parameter to public dictionary APIs, which include:

  1. cudf::dictionary::encode
  2. cudf::dictionary::decode
  3. cudf::dictionary::get_index
  4. cudf::dictionary::add_keys
  5. cudf::dictionary::remove_keys
  6. cudf::dictionary::remove_unused_keys
  7. cudf::dictionary::set_keys
  8. cudf::dictionary::match_dictionaries

Reference 13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 17, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 17, 2023
Signed-off-by: Suraj Aralihalli <[email protected]>
@github-actions github-actions bot added the CMake CMake build issue label Sep 18, 2023
@SurajAralihalli SurajAralihalli marked this pull request as ready for review September 18, 2023 02:43
@SurajAralihalli SurajAralihalli requested a review from a team as a code owner September 18, 2023 02:43
@davidwendt
Copy link
Contributor

Are you using these APIs or do you know anyone who is perhaps?

@SurajAralihalli
Copy link
Contributor Author

Are you using these APIs or do you know anyone who is perhaps?

I'm not aware of anyone who is using these APIs.

@vuule vuule added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 18, 2023
@vyasr
Copy link
Contributor

vyasr commented Sep 20, 2023

/ok to test

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks solid. Will approve once we see tests passing. Thanks for the contribution!

@vuule
Copy link
Contributor

vuule commented Sep 20, 2023

Some DictionaryTests are failing with C++ exception with description "cudf_identify_stream_usage found unexpected stream!" thrown in the test body.

@SurajAralihalli SurajAralihalli marked this pull request as draft September 20, 2023 21:12
@vyasr
Copy link
Contributor

vyasr commented Sep 21, 2023

@SurajAralihalli that failure indicates that somewhere in the call stack the stream is not being passed through and we're probably using cudf::get_default_stream() instead. You'll want to trace that back to its source. A debug build of cudf can be very helpful here, but it's also quite slow so manually tracking may be faster.

@SurajAralihalli
Copy link
Contributor Author

Thankyou @vyasr for the tip!

This PR includes additional changes:

  1. In the column_wrapper.hpp file, it explicitly provides cudf::test::get_default_stream() as an argument to the cudf::dictionary::encode() function.

  2. In the search.cu file, a bug in the find_index_fn has been fixed. The bug involved the incorrect use of cudf::get_default_stream() instead of the stream variable.

@SurajAralihalli SurajAralihalli marked this pull request as ready for review September 22, 2023 05:42
@vuule
Copy link
Contributor

vuule commented Sep 22, 2023

/ok to test

@SurajAralihalli
Copy link
Contributor Author

The code style check encountered an issue because there was an extra blank line in the CmakeLists.txt file. This occurred during the process of resolving merge conflicts on the GitHub UI and was not detected by the pre-commit checker on my local machine. I apologize for this oversight.

@PointKernel
Copy link
Member

/ok to test

@PointKernel PointKernel added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Sep 22, 2023
@vyasr
Copy link
Contributor

vyasr commented Sep 22, 2023

The code style check encountered an issue because there was an extra blank line in the CmakeLists.txt file. This occurred during the process of resolving merge conflicts on the GitHub UI and was not detected by the pre-commit checker on my local machine. I apologize for this oversight.

Good find! Let's see if tests pass this time around.

@vyasr
Copy link
Contributor

vyasr commented Sep 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit f3402c4 into rapidsai:branch-23.10 Sep 25, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants