-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stream parameter to external dict APIs #14115
Add stream parameter to external dict APIs #14115
Conversation
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Are you using these APIs or do you know anyone who is perhaps? |
I'm not aware of anyone who is using these APIs. |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks solid. Will approve once we see tests passing. Thanks for the contribution!
Some |
@SurajAralihalli that failure indicates that somewhere in the call stack the stream is not being passed through and we're probably using |
Signed-off-by: Suraj Aralihalli <[email protected]>
…/cudf into add_stream_to_dictionary
Thankyou @vyasr for the tip! This PR includes additional changes:
|
/ok to test |
Signed-off-by: Suraj Aralihalli <[email protected]>
The code style check encountered an issue because there was an extra blank line in the CmakeLists.txt file. This occurred during the process of resolving merge conflicts on the GitHub UI and was not detected by the pre-commit checker on my local machine. I apologize for this oversight. |
/ok to test |
Good find! Let's see if tests pass this time around. |
/merge |
Description
This PR adds stream parameter to public dictionary APIs, which include:
cudf::dictionary::encode
cudf::dictionary::decode
cudf::dictionary::get_index
cudf::dictionary::add_keys
cudf::dictionary::remove_keys
cudf::dictionary::remove_unused_keys
cudf::dictionary::set_keys
cudf::dictionary::match_dictionaries
Reference 13744
Checklist