Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring parity with pandas for datetime & timedelta comparison operations #13877

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Bring parity with pandas for datetime & timedelta comparison operations #13877

merged 5 commits into from
Aug 14, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Resolves: #13876

This PR brings parity with pandas datetime & timedelta comparison operations by filling the null locations of results with True/False according to the binary operation.

Note: This is only enabled in pandas-compatibility mode.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 14, 2023
@galipremsagar galipremsagar self-assigned this Aug 14, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 14, 2023 17:40
@galipremsagar galipremsagar changed the title Fill na values in pandas-compatibility mode Bring parity with pandas for datetime & timedelta comparison operations Aug 14, 2023
bdice
bdice reviewed Aug 14, 2023
View reviewed changes
python/cudf/cudf/core/column/datetime.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_datetime.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_timedelta.py Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Aug 14, 2023

@galipremsagar At some point I'd like to have a full list of the behaviors that pandas compatibility mode changes. It would be good to document that.

@galipremsagar
Copy link
Contributor Author

@galipremsagar At some point I'd like to have a full list of the behaviors that pandas compatibility mode changes. It would be good to document that.

Agree with you @bdice. I've opened a doc issue to track it: #13878

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 14, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 049248d into rapidsai:branch-23.10 Aug 14, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Parity with pandas for binary operations in datetime & timedelta dtypes
2 participants
@galipremsagar @bdice