Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in parquet/page_decode.cuh #13849

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Fix typo in parquet/page_decode.cuh #13849

merged 3 commits into from
Aug 11, 2023

Conversation

XinyuZeng
Copy link
Contributor

@XinyuZeng XinyuZeng commented Aug 11, 2023 •
edited by PointKernel
Loading

Description

This PR fixes a typo in the parquet page decoding doc and adds a missing doc.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@XinyuZeng XinyuZeng requested a review from a team as a code owner August 11, 2023 07:05
@rapids-bot
Copy link

rapids-bot bot commented Aug 11, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 11, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Aug 11, 2023
@davidwendt
Copy link
Contributor

/ok to test

@PointKernel
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit bf9b110 into rapidsai:branch-23.10 Aug 11, 2023
54 checks passed
@PointKernel
Copy link
Member

@XinyuZeng I've updated the PR description to provide more details. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XinyuZeng @davidwendt @PointKernel @ttnghia