Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relaxes cudf's protobuf pinnings to help with compatibility issues.
cudf
usesprotobuf
in two places.The first place
protobuf
is used is at build time, to generate a Python module from a.proto
file inpython/cudf/cmake/Modules/ProtobufHelpers.cmake
:cudf/python/cudf/cmake/Modules/ProtobufHelpers.cmake
Lines 16 to 17 in f8e5a89
The second place
protobuf
is used is in the generated filepython/cudf/cudf/utils/metadata/orc_column_statistics_pb2.py
which is imported here.The generated Python module used at runtime should be compatible with newer versions of
protobuf
than the version used to build the Python module, from my understanding of https://protobuf.dev/support/cross-version-runtime-guarantee/. Therefore, we only require that the runtime pinning ofprotobuf
is of the same major version and an equal-or-greater minor version. That allows us to relax this pinning.Follow-up to #12864, see that PR for more context.
Checklist