Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDA version to cudf_kafka and libcudf-example build strings. #13769

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add CUDA version to cudf_kafka and libcudf-example build strings. #13769

merged 2 commits into from
Jul 26, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 26, 2023 •
edited
Loading

Description

In #12922, we missed adding a cuda{{ cuda_major }}_ to the cudf-kafka and libcudf-example build strings. This PR fixes that.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner July 26, 2023 18:25
@github-actions github-actions bot added the conda label Jul 26, 2023
@bdice bdice mentioned this pull request Jul 26, 2023
Open
@bdice bdice self-assigned this Jul 26, 2023
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Jul 26, 2023
@bdice
Copy link
Contributor Author

bdice commented Jul 26, 2023

/merge

@bdice
Copy link
Contributor Author

bdice commented Jul 26, 2023 •
edited
Loading

With 38ece37 this is actually complete. I verified all build strings include cuda{{ cuda_major }}_. We'll remove this from some CUDA-independent packages in #13755.

@bdice bdice changed the title Add CUDA version to cudf_kafka build string. Add CUDA version to cudf_kafka and libcudf-example build strings. Jul 26, 2023
@jakirkham jakirkham mentioned this pull request Jul 26, 2023
Merged
@rapids-bot rapids-bot bot merged commit 2231b15 into rapidsai:branch-23.08 Jul 26, 2023
54 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@bdice bdice

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @jakirkham @raydouglass