Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix construction of DataFrames from dict when columns are provided #13766

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Fix construction of DataFrames from dict when columns are provided #13766

merged 2 commits into from
Jul 28, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 26, 2023

Description

If a columns argument is provided to the dataframe constructor, this should be used to select columns from the provided data dictionary. The previous logic did do this correctly, but didn't preserve the appropriate order of the resulting columns (which should come out in the order that the column selection is in).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Fix construction of DataFrames from dict when columns are provided
7bdb3d8 
If a columns argument is provided to the dataframe constructor, this
should be used to select columns from the provided data dictionary.
The previous logic did do this correctly, but didn't preserve the
appropriate order of the resulting columns (which should come out in
the order that the column selection is in).

- Closes rapidsai#13738
@wence- wence- requested a review from a team as a code owner July 26, 2023 11:29
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 26, 2023
@wence- wence- added bug Something isn't working non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Jul 26, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 28, 2023
@galipremsagar
Copy link
Contributor

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 28, 2023
@rapids-bot rapids-bot bot merged commit 2dabf0c into rapidsai:branch-23.10 Jul 28, 2023
54 checks passed
@wence- wence- deleted the wence/fix/issue-13738 branch July 29, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] columns= argument to DataFrame does not correctly select data when data contains labels
2 participants
@wence- @galipremsagar