Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-23.08 to branch-23.10 #13761

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Commits on Jul 26, 2023

  1. Don't test strings shorter than the requested ngram size (#13758)

    The random string generation was using a minimum length of 1 rather than the ngram size. While both the reference implementation and the libcudf code were robust to that case, they return different extreme values (0 vs 1) for those. Since testing that edge case isn't really in scope for this particular test, I've modified the generator to only generate strings whose length is at least the requested ngram size.
    
    Resolves #13748
    
    Authors:
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    Approvers:
      - GALI PREM SAGAR (https://github.com/galipremsagar)
      - Bradley Dice (https://github.com/bdice)
    
    URL: #13758
    vyasr authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d26172f View commit details
    Browse the repository at this point in the history