Skip to content

Commit

Permalink
Fix extract-datetime deprecation warning in ndsh benchmark (#17254)
Browse files Browse the repository at this point in the history
Fixes deprecation warning introduced by #17221 

```
[165+3+59=226] Building CXX object benchmarks/CMakeFiles/NDSH_Q09_NVBENCH.dir/ndsh/q09.cpp.o
/cudf/cpp/benchmarks/ndsh/q09.cpp: In function 'void run_ndsh_q9(nvbench::state&, std::unordered_map<std::__cxx11::basic_string<char>, cuio_source_sink_pair>&)':
/cudf/cpp/benchmarks/ndsh/q09.cpp:148:33: warning: 'std::unique_ptr<cudf::column> cudf::datetime::extract_year(const cudf::column_view&, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated [-Wdeprecated-declarations]
  148 |   auto o_year = cudf::datetime::extract_year(joined_table->column("o_orderdate"));
      |                                 ^~~~~~~~~~~~
In file included from /cudf/cpp/benchmarks/ndsh/q09.cpp:21:
/cudf/cpp/include/cudf/datetime.hpp:70:46: note: declared here
   70 | [[deprecated]] std::unique_ptr<cudf::column> extract_year(
      |                                              ^~~~~~~~~~~~
/cudf/cpp/benchmarks/ndsh/q09.cpp:148:45: warning: 'std::unique_ptr<cudf::column> cudf::datetime::extract_year(const cudf::column_view&, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated [-Wdeprecated-declarations]
  148 |   auto o_year = cudf::datetime::extract_year(joined_table->column("o_orderdate"));
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /cudf/cpp/benchmarks/ndsh/q09.cpp:21:
/cudf/cpp/include/cudf/datetime.hpp:70:46: note: declared here
   70 | [[deprecated]] std::unique_ptr<cudf::column> extract_year(
      |                                              ^~~~~~~~~~~~

```

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Karthikeyan (https://github.com/karthikeyann)
  - Shruti Shivakumar (https://github.com/shrshi)

URL: #17254
  • Loading branch information
davidwendt authored Nov 7, 2024
1 parent e4c52dd commit 1981445
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cpp/benchmarks/ndsh/q09.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ void run_ndsh_q9(nvbench::state& state,

// Calculate the `nation`, `o_year`, and `amount` columns
auto n_name = std::make_unique<cudf::column>(joined_table->column("n_name"));
auto o_year = cudf::datetime::extract_year(joined_table->column("o_orderdate"));
auto o_year = cudf::datetime::extract_datetime_component(
joined_table->column("o_orderdate"), cudf::datetime::datetime_component::YEAR);
auto amount = calculate_amount(joined_table->column("l_discount"),
joined_table->column("l_extendedprice"),
joined_table->column("ps_supplycost"),
Expand Down

0 comments on commit 1981445

Please sign in to comment.