Skip to content

Commit

Permalink
fix shared-memory variable type
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwendt committed Nov 8, 2024
1 parent 4e3e25d commit 056eb79
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cpp/include/nvtext/minhash.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ namespace CUDF_EXPORT nvtext {
* @throw std::overflow_error if `parameter_a.size() * input.size()` exceeds the column size limit
*
* @param input Strings column to compute minhash
* @param seed Seed value used for the hash algorithm
* @param seed Seed value used for the hash algorithm
* @param parameter_a Values used for the permuted calculation
* @param parameter_b Values used for the permuted calculation
* @param width The character width of substrings to hash for each row
Expand Down Expand Up @@ -236,7 +236,7 @@ std::unique_ptr<cudf::column> minhash_permuted(
* @throw std::overflow_error if `parameter_a.size() * input.size()` exceeds the column size limit
*
* @param input Strings column to compute minhash
* @param seed Seed value used for the hash algorithm
* @param seed Seed value used for the hash algorithm
* @param parameter_a Values used for the permuted calculation
* @param parameter_b Values used for the permuted calculation
* @param width The character width of substrings to hash for each row
Expand Down
3 changes: 1 addition & 2 deletions cpp/src/text/minhash.cu
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,7 @@ CUDF_KERNEL void minhash_permuted_kernel(cudf::column_device_view const d_string
constexpr hash_value_type hash_max = std::numeric_limits<hash_value_type>::max();

// found to be an efficient shared memory size for both hash types
__shared__ char shmem[block_size * params_per_thread * sizeof(hash_value_type)];
auto const block_values = reinterpret_cast<hash_value_type*>(shmem);
__shared__ hash_value_type block_values[block_size * params_per_thread];

for (std::size_t i = 0; i < parameter_a.size(); i += params_per_thread) {
// initialize this block's chunk of shared memory
Expand Down

0 comments on commit 056eb79

Please sign in to comment.