-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install imagecodecs and openslide-python dependencies so additional tests will run #634
install imagecodecs and openslide-python dependencies so additional tests will run #634
Conversation
…ll subset of tests
1a9988f
to
ccaa73c
Compare
Co-authored-by: jakirkham <[email protected]>
Okay, libopenslide is now being found and the
|
^ @gigony |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Greg! 🙏
Had a follow up question below (assuming this change works)
ci/test_wheel.sh
Outdated
# TODO: fix and remove two test cases skipped here | ||
# test_cache_hit_miss currently fails | ||
# test_converter passes, but a segfault occurs on pytest exit when it is enabled | ||
python -m pytest ./python/cucim -k "not test_converter and not test_cache_hit_miss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move these to PyTest decorators?
We could also use skipif
to more carefully restrict when they are skipped
@pytest.mark.skip(reason="currently fails")
def test_cache_hit_miss():
...
@pytest.mark.skip(reason="passes, but a segfault occurs on pytest exit when it is enabled")
def test_converter():
...
After a bit of effort Gigon was able to reproduce this when we met yesterday using a Ubuntu 18 Docker container and installing the wheel. With a bit of debugging it appears this goes back to an old cuFile issue that we thought had been fixed with PR ( #158 ). However it appears this issue is back |
After further discussion offline, it sounds like the cuFile bug persists in CUDA 11. So we are opting to skip related tests on CUDA 11 This problem does not occur in CUDA 12. So we run all test there |
After discussion with Greg offline, we decided to move this to 24.02 as we are already in code freeze for 23.12 |
Style check failure is unrelated. It is coming from the version update script. Attempting to address in PR ( #648 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grlee77 ! Looks good to me!
/merge |
Thanks all! 🙏 |
This MR may initially fail during wheel testing due to #626, as a few test cases relying on these packages were not being run at the time #619 was merged.