Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-23.08 to branch-23.10 #602

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-23.08 that creates a PR to keep branch-23.10 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

Since the GPUtil library does not allow us to measure the GPU memory usage for a specific process, we need to take a more cautious approach to gauge GPU usage.

There's a likelihood that the GPU memory usage may not stabilize during the initial iterations, as illustrated below:
```
[12999.0, 14257.0, 14569.0, 14617.0, 14623.0, 14621.0]
```
Rather than evaluating `mem_usage_history[4] - mem_usage_history[1] < 180.0`, we will now measure 10 points, and begin our examination from the midpoint of these points (`mem_usage_history[5] - mem_usage_history[9] < 180.0`).

This change addresses #595.

Authors:
  - Gigon Bae (https://github.com/gigony)

Approvers:
  - https://github.com/jakirkham

URL: #601
@GPUtester GPUtester requested a review from a team as a code owner August 3, 2023 21:39
@GPUtester GPUtester merged commit c0805d9 into branch-23.10 Aug 3, 2023
4 checks passed
@GPUtester
Copy link
Contributor Author

SUCCESS - forward-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants