Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry installs to ci-conda and ci-wheel #196

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

msarahan
Copy link

This is a work in progress; part of https://github.com/rapidsai/build-infra/issues/139. Right now, these installs are being done in workflow scripts, like https://github.com/rapidsai/shared-workflows/blob/add-telemetry/.github/workflows/conda-cpp-build.yaml#L124.

@msarahan msarahan marked this pull request as ready for review October 30, 2024 15:51
@msarahan msarahan requested a review from a team as a code owner October 30, 2024 15:51
@msarahan msarahan requested review from raydouglass and removed request for a team October 30, 2024 15:51
Copy link
Author

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-conda.Dockerfile Outdated Show resolved Hide resolved
ci-wheel.Dockerfile Outdated Show resolved Hide resolved
citestwheel.Dockerfile Outdated Show resolved Hide resolved
pip install opentelemetry-distro[otlp] opentelemetry-exporter-prometheus
opentelemetry-bootstrap -a install
curl -L -o "otel-cli-${CPU_ARCH}.tar.gz" https://github.com/equinix-labs/otel-cli/releases/download/v0.4.5/otel-cli_0.4.5_linux_${CPU_ARCH}.tar.gz
tar -zxf "otel-cli-${CPU_ARCH}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few more files inside this tarball that may need to be cleaned up after extraction (see screenshot below)

image

to avoid having to clean these up, you can specify which files you want to extract like this:

# specify the path of the files you wish to extract from the tarball after the tarball filename
tar -zxf "otel-cli-${CPU_ARCH}.tar.gz" otel-cli

this will ensure that the LICENSE, README.md, and CHANGELOG.md files don't get extracted and clutter up the filesystem.

if you want to get real fancy, you can use a pipe to avoid saving the tarball to the filesystem entirely:

wget -qO- https://github.com/equinix-labs/otel-cli/releases/download/v0.4.5/otel-cli_0.4.5_linux_${CPU_ARCH}.tar.gz | tar xzf - -C /usr/local/bin otel-cli

then you can skip the subsequent rm -rf command altogether.

source: https://unix.stackexchange.com/q/85194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants