Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#675 User requests password reset from Blackberry] #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kishoreyekkanti
Copy link
Contributor

User requesting password reset from blackberry. This has dependency on the webapp pull request https://github.com/jorgej/RapidFTR/pull/216 . Story depends on the json api provided by the password reset request from web app. To test the BB app we need to merge the above mentioned pull request into the webapp.

@kishoreyekkanti
Copy link
Contributor Author

There's some change needed in the pull request based on the suggestion of webapp request here https://github.com/jorgej/RapidFTR/pull/216#issuecomment-3134886 . So, closing this pull request. Will reissue the pull request once the changes are accommodated.

@kishoreyekkanti
Copy link
Contributor Author

Seems like this is working without any change in the BB code, as we depend just on the text coming from the webapp.

@rgan
Copy link
Contributor

rgan commented Mar 31, 2012

Instead of adding a special case to the HttpBatchRequestHandler for the password recovery, I would use the HttpService directly - the post() method takes a listener which can be used to handle the response. The login service class could then implement the listener, and do the custom processing for password recovery there. This also reduces the number of files you will have to modify for this - only the login related classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants