Feature/brands #85
Feature/brands #85
Conversation
BobWez98
commented
Oct 31, 2024
BobWez98
commented
- Refactored the brands import
- Allow a Hybrid runway collection to have a route
- Structured blueprints of runway resources
- Removed old import buttons
| foreach (Brand::get() as $brand) { | ||
| $extraData = []; | ||
|
|
||
| if (Schema::hasTable('amasty_amshopby_option_setting')) { |
There was a problem hiding this comment.
We need this documented somewhere, so we do support Amasty Brands out of the box?
There was a problem hiding this comment.
I have some doubts if we even want this anymore. Let's discuss internally.
| public static function handle(): string | ||
| { | ||
| return 'base'; | ||
| } | ||
|
|
||
| public function title(): string | ||
| { | ||
| return __('Base'); | ||
| } |
There was a problem hiding this comment.
Maybe not specify these as you want these to be required?
There was a problem hiding this comment.
Sadly we have to. The baseCollection of Statamic builder has abstract methods, this requires us to implement it. Can't do it like public function title(): string; either cause it expects an implementation.
| @@ -37,7 +37,7 @@ | |||
| "statamic-rad-pack/runway": "^7.11", | |||
| "statamic/cms": "^5.0", | |||
| "statamic/eloquent-driver": "^4.9", | |||
| "tdwesten/statamic-builder": "^1.0", | |||
| "tdwesten/statamic-builder": "dev-main", | |||
There was a problem hiding this comment.
Put it on dev-main for now, there's no release yet but i added tdwesten/statamic-builder#37
There was a problem hiding this comment.
I suggest flipping this function around for readability.
Could you add a comment to the function on why we cannot do the entry query when running in console
