Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User Agent strings for October 2024 #19540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smashery
Copy link
Contributor

@smashery smashery commented Oct 9, 2024

This also adds a script to automate this in future.

Verification

List the steps needed to make sure this thing works

  • Create some HTTP(S) payloads
  • Validate that they work, and that they are sending valid

Check the script in tools/dev/update_user_agent_strings.py

  • Manually update the lines of the user_agent.rb file and make sure that the script handles it appropriately (usually just a meaningful error message if there's a problem)
  • Check that after success, running it a second time doesn't change anything

Comment on lines +9 to +11
for x in range(0, len(lines)):
if replace_marker in lines[x]:
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for x in range(0, len(lines)):
if replace_marker in lines[x]:
break
for line in lines:
if replace_marker in line:
break

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the script; cross-referencing with: #18120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants