Mettle now copying gem correctly and running acceptance tests #19501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranleese-r7
force-pushed
the
fix-copying-mettle-gem-accpetance-tests
branch
from
e5d995c
to
11b5a1c
Compare
adfoster-r7
approved these changes
Sep 25, 2024
adfoster-r7
added
rn-no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and issue that was introduced as part of #19413. This PR updates the
cpto now copy with the correct paths as well as an additional fix to pull out the current metasploit-framework Mettle version so it can be replaced withinmetasploit-framework.gemspec.Verification
List the steps needed to make sure this thing works