Rename Acceptance::Meterpreter module to Acceptance::Session
#19428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Aug 28, 2024
cgranleese-r7
force-pushed
the
rename-meterpreter-module-to-session
branch
from
6398e25
to
5d49b85
Compare
adfoster-r7
reviewed
Aug 28, 2024
adfoster-r7
reviewed
Aug 28, 2024
| return true if ENV['METERPRETER'].blank? | ||
| # Allows restricting the tests of a specific session's test suite with the SESSION environment variable | ||
| # @return [TrueClass, FalseClass] True if the given session should be run, false otherwise. | ||
| def self.run_session?(session_config) |
There was a problem hiding this comment.
I think we still want unique identifiers here for environment variables, for the scenario of running the test suite all at once instead of on a per-file basis 🤔
I think we should either revert run_meterpreter? and run_meterpreter_module_test?, or update it to take a parameter of the session type that's expected
There was a problem hiding this comment.
Happy to jump on a call if you disagree with that approach, i.e. if I'm missing an edgecase or such and you'd prefer to follow a different pattern
cgranleese-r7
force-pushed
the
rename-meterpreter-module-to-session
branch
from
5d49b85
to
37cedf8
Compare
2 tasks
cgranleese-r7
force-pushed
the
rename-meterpreter-module-to-session
branch
2 times, most recently
from
1d331e7
to
ceffede
Compare
cgranleese-r7
force-pushed
the
rename-meterpreter-module-to-session
branch
from
ceffede
to
76b0bc5
Compare
cgranleese-r7
added a commit
to cgranleese-r7/metasploit-framework
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
Acceptance::Meterpretermodule toAcceptance::Session. This has been done as more tests have now been added to our acceptance testing. In this PR we will be adding command shell acceptance testing ontop of our existing Meterpreter testing. So this PR is in preparation to adding those new tests.Verification