Skip to content

Commit

Permalink
comment conf file (#160)
Browse files Browse the repository at this point in the history
* Creating a  array that content all the patterns used in the class, this allow if in the feature we want to create a new featured that include patterns we cant add this for a best readeability (some patterns get really complicated

* Modifying all the sugestion from rap2hpoutre in the PR comments

* Log Location customisable #139

* changing storage_path() to ->storage_path

* Fixing error Cannot use object of type Rap2hpoutre\LaravelLogViewer\Pattern as array

 + changing array to not static + creating new function getPattern

*  fixing Codacy/PR Quality Review

* Adding .idea to gitignore file + adding comments to config file
Merge remote-tracking branch 'upstream/master'

# Conflicts:
#	src/Rap2hpoutre/LaravelLogViewer/LaravelLogViewer.php
#	src/Rap2hpoutre/LaravelLogViewer/Pattern.php
  • Loading branch information
elminson authored and rap2hpoutre committed Jul 18, 2018
1 parent 3790892 commit 45872ed
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/vendor
composer.lock
/.idea
1 change: 0 additions & 1 deletion src/Rap2hpoutre/LaravelLogViewer/Pattern.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,4 @@ public function getPattern($pattern, $position = null)
return $this->patterns[$pattern];

}

}
8 changes: 8 additions & 0 deletions src/config/logviewer.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
<?php

return [
/*
|--------------------------------------------------------------------------
| Pattern and storage path settings
|--------------------------------------------------------------------------
|
| The env key for pattern and storage path with a default value
|
*/
'pattern' => env('LOGVIEWER_PATTERN', '*.log'),
'storage_path' => env('LOGVIEWER_STORAGE_PATH', 'logs'),
];

0 comments on commit 45872ed

Please sign in to comment.