Include support for HTTPS POST of data to HTTPS Server (e.g. emoncms.org for heatpumpmonitor.org) #2 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really useful addition to the ESPAltherma software. As Phil says, it removes the need for HA/local EmonCMS, and also simplifies processing with the 0/1 Off/On change. |
reedy
reviewed
Nov 18, 2024
| { | ||
| String httpRequestData = "node=" + String(NODE) + "&data=" + String(httpsbuff) + "&apikey=" + APIKEY; //Build the Emoncms data string | ||
|
|
||
| static WiFiClientSecure client; |
There was a problem hiding this comment.
Looks like this line and the one above it should be indented a couple of spaces
|
|
||
|
|
||
|
|
||
|
|
| #define APIKEY " " //emoncms | ||
| #define NODE "emontx" // node in emoncms | ||
|
|
||
| // root certificate of emoncms.org - expires 2038 |
There was a problem hiding this comment.
Obviously if they change who provides their cert chain...
Their current certs are 3 months...
What's the error handling like if the cert no longer validates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a heat pump installer I am keen to make sure that I can provide the best service to my clients.
I also have some coding experience (not loads, so please go easy on me).
Daikin's StandByMe professional portal gives very limited data to the installer, whilst this project gives excellent coverage, and if implemented, would allow installers to really optimise their installations and up their game.
In order to draw the charts in the same format as heatpumpmonitor.org using the app in openenergymonitor.org, the data needs to be sent as a HTTP POST to an instance of emoncms (normally emoncms.org). I took this one step further and implemented HTTPS, which may be unnecessary, but offers future proofing.
After discussion on openenergymonitor forum, it was pointed out that if an installer wanted to do this, then they also would need a local MQTT broker and a means of forwarding the data as HTTP. This would normally mean a homeassistant device / raspberry PI as well (i.e. a second box of some type), and at this point it's inefficient for a heat pump installer to bring and setup all this kit, and could result in repeat visits to a client to resolve IT issues.
This pull request is to bring in the HTTPS POST directly into the main program, so that the option exists to send Daikin (and other brands) data directly via https post to emoncms and other web servers to allow for the charting to work from this data.
This version is cleaner than my previous pull request as the https.h contains all the https related functions, rather than having them in the mqtt.h file.
I've taken on board the comments from @arc12 (Adam Cooper), thanks for taking the time to review.
I've also added an option in converters.h to have the 'simple' boolean data reported as 1/0 rather than ON/OFF in case the destination requires (this is the case with emoncms.org).
Thanks for your consideration, and also to my co-author Ice and Rock.