Add sync versions of stream and save methods #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should solve the issue: #194
The implementation is a bit more complicated than the simplest asyncio.run() of the save and stream methods.
That's because I've wanted to use this synchronous interface in my Fastapi app, and simple asyncio.run() would give me errors that the event loop is alread running. That's because Fastapi is itself async, and I would run synchronous function inside async fastapi handler, and then from this synchronous function I wanted to call edge-tts generation. I've reproduced similar scenario in two example files: examples/sync_audio_generation_in_async_context.py and examples/sync_audio_stream_in_async_context.py.
I've roughly checked the performance of my solution and from what I've saw there should be no visible performance hit when using ThreadPoolExecutor instead of just asyncio.run().