Exclude streamlit version 1.34 from requirements #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansthen
force-pushed
the
exclude_version_1.34
branch
from
b8e8d07
to
3604740
Compare
|
The issue has been noted by the streamlit team: streamlit/streamlit#8606. Since the issue seemingly only affects the tests, I only disabled 1.34.0 for the tests. |
hansthen
force-pushed
the
exclude_version_1.34
branch
from
0aebdcf
to
d04154d
Compare
randyzwitch
approved these changes
May 6, 2024
raethlein
added a commit
to streamlit/streamlit
that referenced
this pull request
May 6, 2024
## Describe your changes Closes #8606 The PR allows custom component modules to be executed standalone by not registering them with Streamlit at all, which makes sense since Streamlit is not started. It's a cherry-pick of this broader PR #8610, which also adds tests. However, we want to discuss our testing strategy first, so we decouple it from adding the fix (see for example also this PR #8616). ## GitHub Issue Link (if applicable) - #8606 - NathanChen198/streamlit-rsa-auth-ui#1 - randyzwitch/streamlit-folium#186 ## Testing Plan - E2E Tests: tests to ensure this behavior will come in a separate PR, see #8616 and #8610 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
benjamin-awd
pushed a commit
to benjamin-awd/streamlit
that referenced
this pull request
Sep 29, 2024
## Describe your changes Closes streamlit#8606 The PR allows custom component modules to be executed standalone by not registering them with Streamlit at all, which makes sense since Streamlit is not started. It's a cherry-pick of this broader PR streamlit#8610, which also adds tests. However, we want to discuss our testing strategy first, so we decouple it from adding the fix (see for example also this PR streamlit#8616). ## GitHub Issue Link (if applicable) - streamlit#8606 - NathanChen198/streamlit-rsa-auth-ui#1 - randyzwitch/streamlit-folium#186 ## Testing Plan - E2E Tests: tests to ensure this behavior will come in a separate PR, see streamlit#8616 and streamlit#8610 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It breaks the automated tests.
The test_package.py and test_release.py fail with error message: "RuntimeError: Runtime hasn't been created!"
Reverting to Streamlit 1.33 solved the issue.