Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Ring Map #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

waringa-mercy
Copy link

@rand00 This are my latest changes. kindly review and advice. Apologies for the confusion by earlier commits

@waringa-mercy
Copy link
Author

@rand00 I hope the latest changes are adequate. the map_rev_shortcuicuit is now defined inside Ring module. The map_rev_shortcircuit function takes a function f and a ring r, and applies f to the elements of the ring in reverse order until either f returns None or all elements have been processed. If f returns None for an element, processing stops and the remaining elements are set to None in the copied ring. The function returns a new ring with the modified elements, or with None in the remaining elements if f returned None for one of them.

@waringa-mercy
Copy link
Author

@rand00 whenever you can, kindly review the changes i made

@waringa-mercy waringa-mercy changed the title latest changes Implement Ring Map Apr 4, 2023
@rand00
Copy link
Owner

rand00 commented Apr 4, 2023

I will have a look when I have more time, as the application period is over there is some other Outreachy things that need to be looked at. But again, thank you for contributing!

@waringa-mercy
Copy link
Author

@rand00 understood. thank you for the mentorship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants