Bugfix: Inonsistent Brew & Steam switch behaviours #413 #414 #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjyv
reviewed
Dec 12, 2023
kjyv
previously approved these changes
Dec 13, 2023
LoQue90
requested changes
Dec 13, 2023
|
Thanks for testing again. My review was not based on actually testing this as I don't have a push button installed in my machine, guess I should have added that caveat |
don´t worry, the code is fine and works. |
…bled debounce. Trigger time measurement & print to debug if VERBOSE. Debounce times to 20ms. Added variable brewSwitchLongPress to brewscale.ini, set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMEDISPLAY, adapt comments to fit to functionality.
genkigenki
force-pushed
the
BugfixBrewSteamPushbuttons
branch
from
58e699f
to
b9c6e7d
Compare
…om/genkigenki/clevercoffee into pr/417" This reverts commit 15b9ea0, reversing changes made to 1bc966d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brew button was not debounced, leading to erratic behaviour if your switches are not perfect.
5s delay removed, as its not needed (was likely introduced due to erratic behaviour due to bouncing switches)
Fixes #413
Steam button configured as push button was twice checked and once not debounced. Removed check in main.cpp. Also migrated missing code to switchvoid file from main to ensure behaviour for switch users stays same.
Fixes #416