-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Inonsistent Brew & Steam switch behaviours #413 #414 #417
Bugfix: Inonsistent Brew & Steam switch behaviours #413 #414 #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although not sure about the 5 second delay. Could this be there for making the (software) brew detection work? The comment mentions that. So please test if it is really unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works worse than befor. dosen´t react to all pushes, brew start/stops not reliable
debounceDelayBrewTrigger set to 80 for test, did not help
Thanks for testing again. My review was not based on actually testing this as I don't have a push button installed in my machine, guess I should have added that caveat |
don´t worry, the code is fine and works. |
…bled debounce. Trigger time measurement & print to debug if VERBOSE. Debounce times to 20ms. Added variable brewSwitchLongPress to brewscale.ini, set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMEDISPLAY, adapt comments to fit to functionality.
58e699f
to
b9c6e7d
Compare
…om/genkigenki/clevercoffee into pr/417" This reverts commit 15b9ea0, reversing changes made to 1bc966d.
Brew button was not debounced, leading to erratic behaviour if your switches are not perfect.
5s delay removed, as its not needed (was likely introduced due to erratic behaviour due to bouncing switches)
Fixes #413
Steam button configured as push button was twice checked and once not debounced. Removed check in main.cpp. Also migrated missing code to switchvoid file from main to ensure behaviour for switch users stays same.
Fixes #416