-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web page proposal for Version 4.0.0 ESP32 #404
Web page proposal for Version 4.0.0 ESP32 #404
Conversation
- Change API path from AsynWebServer - Include new web page
Sorry, not going to review this in its current state. It looks like 90% unnecessary whitespace changes. Please don't just hit format document in your editor. |
This deletes all of the existing webinterface in favor of one minified js file - how is this supposed to be maintained? (or even reviewed) |
Hi, Please provide a suitable You are right, this PR can't be reviewed properly. I have marked the PR as draft. If its okay I would leave the PR open to be used as a showcase and maybe for you to give feedback on the design of the web page, so we can see if you are at all interested in something like this. The proposal for the web page requires a different approach than the current implementation. That is why we need to decide where the source code of the web page should be available, because in the end only minified code should be in the
|
I think there was discussion about the .editorconfig and that this is a local file. In any case, we have no automatic rules set up yet for formatting, so please don't use that feature in VS Code on complete files. The current quasi style we have has { after the line, not on a new line btw. |
The Okay, nice. Thanks for the input. That would be nice if it can be build automatically. I'm not very familiar with platform io, so I would definitely need your help there. |
We added a CONTRIBUTING file as a reference for the code style. I think this is more flexible and allows for exceptions when they make sense. |
@Clemens-Toegel: Are you still planning to publish the code? Otherwise I would close this PR. |
After discussing this further, this is currently not a priority for the project. Feel free to open a new PR once the code is published and you have a detailed workflow for how to build and maintain the code. |
As promised here is my redesign of the web page on the microcontroller.