Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ngrok ingress for chart museum when running locally #889

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Use ngrok ingress for chart museum when running locally, this is similar to what we did with Gitea some time ago.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Danil-Grigorev
Danil-Grigorev previously approved these changes Dec 2, 2024
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of questions

test/e2e/config/operator.yaml Show resolved Hide resolved
test/testenv/charmuseum.go Show resolved Hide resolved
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexander-demicev alexander-demicev merged commit 3ca310f into rancher:main Dec 2, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the museumfix branch December 2, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants