-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add new e2e test suite for v2prov #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
force-pushed
the
e2e_v2prov
branch
3 times, most recently
from
October 3, 2023 05:04
d897ce1
to
bca7a3b
Compare
richardcase
changed the title
[WIP] Add new e2e test suite for v2prov
test: Add new e2e test suite for v2prov
Oct 3, 2023
salasberryfin
previously approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this e2e require additional variables in the nightly job?
This change adds a new e2e test suite that checks that installing Rancher Turtles doesn't break v2prov. The test will provision a RKE2 cluster in Azure. It will then connect to the cluster via the kubeconfig. Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
e2e_v2prov
branch
from
October 3, 2023 08:44
bca7a3b
to
285f1e3
Compare
Danil-Grigorev
previously approved these changes
Oct 3, 2023
furkatgofurov7
previously approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
richardcase
dismissed stale reviews from furkatgofurov7 and Danil-Grigorev
via
October 3, 2023 09:07
a9ac80a
Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
e2e_v2prov
branch
from
October 3, 2023 09:15
a9ac80a
to
8ab5158
Compare
furkatgofurov7
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a new e2e test suite that will ensure that v2prov doesn't break with Rancher Turtles installed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #106
Special notes for your reviewer:
Checklist: