Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image pull secrets value to chart #147

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:
With Rancher Prime registry I assume users will need a way to pass image pull secret for a private registry to our helm chart. This PR adds a helm chart value for it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

salasberryfin
salasberryfin previously approved these changes Sep 26, 2023
@alexander-demicev alexander-demicev merged commit a62d4c1 into rancher:main Sep 27, 2023
8 checks passed
@alexander-demicev alexander-demicev deleted the imagepullsecrets branch September 27, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants