Skip to content

Commit

Permalink
chart: core-provider remove inconsistent pre-delete hook (#858)
Browse files Browse the repository at this point in the history
In #454 the pre-delete hook was removed from the Namespace and in #508
it was removed from the CAPIProvider

However the pre-delete hook remains on the ConfigMap, which means if
installation fails for any reason prior to creating the Namespace in
the post-install hook, the chart can become undeletable with an error
like:

+ helm_v3 uninstall rancher-turtles --namespace rancher-turtles-system --wait
Error: warning: Hook pre-delete rancher-turtles/templates/core-provider.yaml failed: 1 error occurred:
	* namespaces "capi-system" not found
  • Loading branch information
hardys authored Nov 18, 2024
1 parent a56b877 commit a6e4ae7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/rancher-turtles/templates/core-provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ metadata:
name: capi-additional-rbac-roles
namespace: {{ index .Values "cluster-api-operator" "cluster-api" "core" "namespace" }}
annotations:
"helm.sh/hook": "post-install, post-upgrade, pre-delete"
"helm.sh/hook": "post-install, post-upgrade"
"helm.sh/hook-weight": "2"
data:
manifests: |-
Expand Down

0 comments on commit a6e4ae7

Please sign in to comment.