dev/k3d-act-clean cleanup #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up downstream clusters if FLEET_E2E_DS_CLUSTER_COUNT is set - Remove cleaning up any docker containers by name, including from nektos/act, therefore renaming k3d-act-clean to k3d-clean.
manno
reviewed
Dec 19, 2024
| if [[ $i -ne 1 ]]; then | ||
| cluster="${cluster}${i}" | ||
| fi | ||
| k3d cluster create "${cluster}" \ |
There was a problem hiding this comment.
I would omit the curlies, not needed for variable expansion or to protect the name 🤷
manno
reviewed
Dec 19, 2024
| @@ -7,7 +7,7 @@ export CUSTOM_CONFIG_FILE="env.single-cluster" | |||
| source ./dev/setup-cluster-config | |||
|
|
|||
| # Cleans with settings sourced, so it should be rather selective. | |||
| ./dev/k3d-act-clean | |||
| ./dev/k3d-clean | |||
|
|
|||
| RANDOM_PORT=0 | |||
| if [ -z ${external_ip} ]; | |||
There was a problem hiding this comment.
Always guard against globbing and word splitting.
Suggested change
| if [ -z ${external_ip} ]; | |
| if [ -z "$external_ip" ]; |
manno
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nektos/act, therefore renaming k3d-act-clean to k3d-clean.
Follow-up for #3139