Refactor grutils/gitops controller #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
approved these changes
Oct 24, 2024
manno
force-pushed
the
refactor-grutils-gitops-controller
branch
from
923b8c5
to
530fb59
Compare
0xavi0
approved these changes
Oct 24, 2024
* move all gitrepo utils into reconciler, who is the only consumer * make funcs private, move update funcs into main reconcilers file
Separate the gitjob status fields and conditions from the observability status fields.
manno
force-pushed
the
refactor-grutils-gitops-controller
branch
from
530fb59
to
fa42297
Compare
aruiz14
added a commit
to aruiz14/fleet
that referenced
this pull request
Oct 30, 2024
Refactor grutils/gitops controller: * remove grutil package and unexport functions * move all gitrepo utils into reconciler, who is the only consumer
manno
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Partial backport of #2997 Refactor grutils/gitops controller: * remove grutil package and unexport functions * move all gitrepo utils into reconciler, who is the only consumer * Avoid modifying summary directly * Avoid listing BundleDeployments twice * Backport #3027 GitRepo resources list doesn't list resources multiple times * Add comment to merge * Fix summary import
aruiz14
added a commit
that referenced
this pull request
Nov 7, 2024
GitRepo status resources improvements * Partial backport of #2997 Refactor grutils/gitops controller: * remove grutil package and unexport functions * move all gitrepo utils into reconciler, who is the only consumer * Avoid modifying summary directly * Avoid listing BundleDeployments twice * Backport #3027 GitRepo resources list doesn't list resources multiple times * Add comment to merge * Fix summary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2995
This is preparation for fixes to the status/display/summary code.
separate commits for review, will need to squash.