Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istio 1.23 #4505

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Istio 1.23 #4505

merged 7 commits into from
Oct 8, 2024

Conversation

diogoasouza
Copy link
Contributor

@diogoasouza diogoasouza requested a review from a team as a code owner September 27, 2024 22:13
@diogoasouza diogoasouza force-pushed the istio-1.23 branch 3 times, most recently from c9a88a5 to 954f4c7 Compare October 7, 2024 21:03
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@rancher rancher deleted a comment from github-actions bot Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

adamkpickering
adamkpickering approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@adamkpickering adamkpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diogoasouza diogoasouza merged commit 8dc3060 into rancher:dev-v2.9 Oct 8, 2024
6 checks passed
@kevin-messer-jemmic
Copy link

Hi @diogoasouza and @adamkpickering, the chart of rancher-istio version 104.5.0+up1.23.2 has not been published to https://charts.rancher.io. Do you know how much time it takes to release it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkpickering adamkpickering adamkpickering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diogoasouza @kevin-messer-jemmic @adamkpickering