Disable the virtiofs mount type #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
previously approved these changes
Mar 7, 2024
| if (disabled) { | ||
| tooltip = { content: this.t(`prefs.onlyWithVZ_${ this.arch }`) }; | ||
| } | ||
| let tooltip = { content: this.t('prefs.virtiofsDisabled')}; |
There was a problem hiding this comment.
It might have been easier to just duplicate the text for both options instead of changing the code, but this is fine too (and we'd have need to change it to show the correct text on Linux anyway).
| return false; | ||
| } | ||
| } | ||
| if (desiredValue === VMType.QEMU) { |
There was a problem hiding this comment.
There's no need to take this out (because it'll just never be executed, and we'll need it later).
There was a problem hiding this comment.
I was thinking about this at first, but I think we will just revert this whole PR when we re-enable virtiofs, and then make any other required changes as a followup.
jandubois
force-pushed
the
virtiofs
branch
2 times, most recently
from
06e870d
to
5fc0f94
Compare
mook-as
previously approved these changes
Mar 7, 2024
Testing with virtiofs on Linux has wiped out the HOME directory on the host, and a recent Lima issue claims that they experienced data loss with virtiofs on macOS as well. Signed-off-by: Jan Dubois <[email protected]>
mook-as
reviewed
Mar 7, 2024
mook-as
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with virtiofs on Linux has wiped out the HOME directory on the host, and a recent Lima issue claims that they experienced data loss with virtiofs on macOS as well.
Ref #6582 and lima-vm/lima#2221
With this PR the option is still shown in the Preferences dialog, but permanently disabled:
A settings migration will automatically change
virtiofstoreverse-sshfs.And the settings validator will reject the setting: