Avoid wiping out writable host mounts under /home #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of lima-vm/lima#2234 Replaces 81cdd3c Signed-off-by: Jan Dubois <[email protected]>
mook-as
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
This looks better.
There are changes I'd have made, but they're not important and not touching upstream code seems saner.
I only looked at 04-persistent-data-volume.sh.
I think lima-vm/alpine-lima#123 would help reduce some of the complexity, but we'll have to see once that is actually done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of lima-vm/lima#2234
Replaces 81cdd3c