Respect boolean parameter ylabel (disable when False) #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the parameter =ylabel= is ignored and the hard-coded ylable is written regardless of the =ylable= parameter is truthy or falsy. This change will not set an ylable for the chart if the =ylable= parameter is set to a falsy value. In a next step one could check if =ylable= is a String and if so, set the actual ylable string to that string.
|
Since this library no longer seems to be maintained, we have created a duplicate of it that we plan to maintain and improve over time. If you'd like to use our version check it out here: https://github.com/Lumiwealth/quantstats_lumi Please feel free to fork and send your pull request to this new library, we will be actively monitoring the library and approving PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the parameter =ylabel= is ignored and the hard-coded ylable is written regardless of the =ylabel= parameter is truthy or falsy.
This change will not set an ylable for the chart if the =ylabel= parameter is set to a falsy value.
In a next step one could check if =ylable= is a String and if so, set the actual ylable string to that string.