Support slack markdown message #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcard
reviewed
Apr 24, 2019
|
|
||
| protected final void reply(WebSocketSession session, Event event, String text, boolean mrkdwn) { | ||
| Message message = new Message(text); | ||
| message.setMrkdwn(mrkdwn); | ||
| reply(session, event, new Message(text)); |
There was a problem hiding this comment.
Suggested change
| reply(session, event, new Message(text)); | |
| reply(session, event, message); |
Should it be passing in the message you build to the reply method?
There was a problem hiding this comment.
Yes, as you have built the message in the previous line, you can directly pass it to reply() method. Also, can you please share me the link to the Slack API documentation which shows the mrkdwn property?
There was a problem hiding this comment.
i saw mrkdwn property from this url :)
https://api.slack.com/docs/message-formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added slack markdown message boolean at slack.Bot::reply