Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various formatting & accessibility issues #479

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

gordlin
Copy link
Member

@gordlin gordlin commented Dec 3, 2024

Related Item(s)

Issues:
#451
#434
#435
#463

Changes

Testing

Steps:

#434, #435:

  1. Open a product with history (e.g. 00000000-0000-0000-0000-000000000000).
  2. Open the product history table by clicking Show previous versions of product. The table should be properly formatting, without extra shadow to the right.

#451:

  1. For any product, add some changes and press save. See the new save warning text.
  2. Change to French and repeat step 1. Notice that the save success message now has french text too.

#463:

  1. On the editor, tab to the Preview dropdown button.
  2. Once you reach it, it should automatically show the dropdown upon focus, allowing you to tab to the language options.

This change is Reviewable

@gordlin gordlin added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/formatting-issues

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gordlin)


src/lang/lang.csv line 60 at r1 (raw file):

editor.editMetadata.message.successfulSave,Successfully saved changes!,1,Modifications enregistrées avec succès!,0
editor.editMetadata.message.wait,Please wait. Saving may take a few moments.,1,"Veuillez patienter. L'enregistrement peut prendre quelques instants.",0
editor.editMetadata.message.saveSuccess,Successfully saved changes!,1,Modifications enregistrées avec succès !,0

There's an extra space here in the French translation: succès !, other than that :lgtm:

Copy link
Member Author

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)


src/lang/lang.csv line 60 at r1 (raw file):

Previously, RyanCoulsonCA (Ryan Coulson) wrote…

There's an extra space here in the French translation: succès !, other than that :lgtm:

Donethanks!

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gordlin)


src/lang/lang.csv line 60 at r3 (raw file):

editor.editMetadata.message.successfulSave,Successfully saved changes!,1,Modifications enregistrées avec succès!,0
editor.editMetadata.message.wait,Please wait. Saving may take a few moments.,1,"Veuillez patienter. L'enregistrement peut prendre quelques instants.",0
editor.editMetadata.message.saveSuccess,Successfully saved changes!,1,Modifications enregistrées avec succès!,0

Seems like you duplicated theeditor.editMetadata.message.successfulSave key. You can probably just stick with the old one.

Copy link
Member Author

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @IshavSohal and @RyanCoulsonCA)


src/lang/lang.csv line 60 at r3 (raw file):

Previously, IshavSohal (Ishav Sohal) wrote…

Seems like you duplicated theeditor.editMetadata.message.successfulSave key. You can probably just stick with the old one.

Donethanks!

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 1 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

@yileifeng yileifeng merged commit f664246 into ramp4-pcar4:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants