-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various formatting & accessibility issues #479
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/formatting-issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gordlin)
src/lang/lang.csv
line 60 at r1 (raw file):
editor.editMetadata.message.successfulSave,Successfully saved changes!,1,Modifications enregistrées avec succès!,0 editor.editMetadata.message.wait,Please wait. Saving may take a few moments.,1,"Veuillez patienter. L'enregistrement peut prendre quelques instants.",0 editor.editMetadata.message.saveSuccess,Successfully saved changes!,1,Modifications enregistrées avec succès !,0
There's an extra space here in the French translation: succès !
, other than that
746b757
to
e72b137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
src/lang/lang.csv
line 60 at r1 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
There's an extra space here in the French translation:
succès !
, other than that
Donethanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gordlin)
src/lang/lang.csv
line 60 at r3 (raw file):
editor.editMetadata.message.successfulSave,Successfully saved changes!,1,Modifications enregistrées avec succès!,0 editor.editMetadata.message.wait,Please wait. Saving may take a few moments.,1,"Veuillez patienter. L'enregistrement peut prendre quelques instants.",0 editor.editMetadata.message.saveSuccess,Successfully saved changes!,1,Modifications enregistrées avec succès!,0
Seems like you duplicated theeditor.editMetadata.message.successfulSave
key. You can probably just stick with the old one.
e72b137
to
15155ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @IshavSohal and @RyanCoulsonCA)
src/lang/lang.csv
line 60 at r3 (raw file):
Previously, IshavSohal (Ishav Sohal) wrote…
Seems like you duplicated the
editor.editMetadata.message.successfulSave
key. You can probably just stick with the old one.
Donethanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 1 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
Related Item(s)
Issues:
#451
#434
#435
#463
Changes
Please wait. Saving may take a few moments.
), and add i18n for save success toast.Testing
Steps:
#434, #435:
00000000-0000-0000-0000-000000000000
).Show previous versions of product
. The table should be properly formatting, without extra shadow to the right.#451:
#463:
Preview
dropdown button.This change is