Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix switching between tabs when editing dynamic panel #262

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix switching between tabs when editing dynamic panel #262

merged 1 commit into from
Mar 12, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Mar 5, 2024 •
edited by yileifeng
Loading

Related to #258

This PR fixes an issue where you can't switch back to the panel collection tab after visiting the collection and switching back to the text editor.

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-258/#/en/editor

szczz
szczz approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

dnlnashed
dnlnashed approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

yileifeng
yileifeng approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

KashishMistry
KashishMistry approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@KashishMistry KashishMistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit c43cd4b into ramp4-pcar4:main Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlnashed dnlnashed dnlnashed approved these changes

@KashishMistry KashishMistry KashishMistry approved these changes

@yileifeng yileifeng yileifeng approved these changes

@szczz szczz szczz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RyanCoulsonCA @szczz @yileifeng @KashishMistry @dnlnashed