Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage of .available property #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdzombak
Copy link

@cdzombak cdzombak commented Sep 25, 2024

Summary by Sourcery

Fix the incorrect usage of the .available property in the BlasterStatusRESTResource class by removing the method call parentheses.

Bug Fixes:

  • Fix incorrect usage of the .available property by removing the method call parentheses.

Copy link
Contributor

sourcery-ai bot commented Sep 25, 2024

Reviewer's Guide by Sourcery

This pull request fixes an incorrect usage of the .available property in the BlasterStatusRESTResource class. The change replaces a method call available() with the correct property access available.

Sequence Diagram

No sequence diagram generated.

File-Level Changes

Change Details Files
Corrected the usage of the available property
  • Changed get_blaster(attr, value).available() to get_blaster(attr, value).available
app/app.py

Tips and commands
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cdzombak - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Good catch on the property usage. Consider searching for similar instances of this mistake elsewhere in the codebase to ensure consistent usage.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant