Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed 'web_url' to 'url' #113

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Oct 30, 2023

Description

Changed 'web_url' variable name to be 'url' so that it is consistent across frontend and backend

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2428ccc) 88.27% compared to head (7cff6c0) 88.27%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #113   +/-   ##
========================================
  Coverage    88.27%   88.27%           
========================================
  Files           29       29           
  Lines         1356     1356           
  Branches       411      411           
========================================
  Hits          1197     1197           
  Misses         156      156           
  Partials         3        3           
Files Coverage Δ
src/app.types.tsx 100.00% <ø> (ø)
src/catalogue/catalogue.component.tsx 97.77% <ø> (ø)
...catalogue/items/catalogueItemsDialog.component.tsx 99.67% <100.00%> (ø)
...ogue/items/catalogueItemsLandingPage.component.tsx 100.00% <ø> (ø)
.../catalogue/items/catalogueItemsTable.component.tsx 67.79% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ral-facilities/inventory-management-system-api#99 (review). Should be merged at the same time.

@MatteoGuarnaccia5 MatteoGuarnaccia5 merged commit 45e7d3f into develop Nov 1, 2023
3 checks passed
@MatteoGuarnaccia5 MatteoGuarnaccia5 deleted the change-web_url-to-url branch November 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants