Fix missing optional types on ClientSessions #441 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #446 +/- ##
========================================
Coverage 97.91% 97.91%
========================================
Files 48 48
Lines 1723 1723
========================================
Hits 1687 1687
Misses 36 36 ☔ View full report in Codecov by Sentry. |
3 tasks
VKTB
reviewed
Jan 14, 2025
inventory_management_system_api/repositories/catalogue_category.py
Outdated
Show resolved
Hide resolved
VKTB
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #441. Also done to object-storage-api here: ral-facilities/object-storage-api#90.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #441