Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pydantic v2 #92 #110

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Migrate pydantic v2 #92 #110

merged 6 commits into from
Nov 3, 2023

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Nov 3, 2023

Description

Once merged any venv should be updated, or if you use docker run docker compose build to ensure the new version of pydantic is installed.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

Closes #92

@joelvdavies joelvdavies added the dependencies Pull requests that update a dependency file label Nov 3, 2023
@joelvdavies joelvdavies mentioned this pull request Nov 3, 2023
2 tasks
@joelvdavies joelvdavies force-pushed the migrate-pydantic-v2-#92 branch from 4950050 to 9817a22 Compare November 3, 2023 13:54
@joelvdavies joelvdavies marked this pull request as ready for review November 3, 2023 14:49
@joelvdavies
Copy link
Collaborator Author

joelvdavies commented Nov 3, 2023

I also approve (but cant request a review of myself as I created the PR)

@VKTB VKTB merged commit 9821528 into develop Nov 3, 2023
4 checks passed
@VKTB VKTB deleted the migrate-pydantic-v2-#92 branch November 3, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade FastAPI & pydantic
2 participants