Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change address fields #107 #108

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Change address fields #107 #108

merged 7 commits into from
Nov 17, 2023

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Nov 2, 2023

Description

Changed address fields so that it can be used internationally. Updated tests accordingly

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #107

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the title Change address fields Change address fields #107 Nov 2, 2023
@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review November 2, 2023 11:45
@VKTB VKTB requested a review from joelvdavies November 7, 2023 16:46
Base automatically changed from additional-manufacturer-details to develop November 8, 2023 10:05
@VKTB VKTB linked an issue Nov 8, 2023 that may be closed by this pull request
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelvdavies joelvdavies merged commit 0386f52 into develop Nov 17, 2023
4 checks passed
@joelvdavies joelvdavies deleted the address-field-changes-#107 branch November 17, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address input field to become international standard
3 participants