Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implement UI display with manual scroll for Carousel View (RMCCX-7619) #340

Merged
merged 19 commits into from
Dec 20, 2024

Conversation

SoumenRautray
Copy link
Contributor

@SoumenRautray SoumenRautray commented Dec 9, 2024

Description

Implemented UI display with manual scroll for Carousel View .

Links

[RMCCX-7619]

Checklist

  • I have read the contributing guidelines
  • I have added to the changelog
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I ran fastlane ci without errors
  • All project file changes are replicated in SampleSPM/SampleSPM.xcodeproj project

Sources/RInAppMessaging/CampaignDispatcher.swift Outdated Show resolved Hide resolved
}
}

class CarouselCell: UICollectionViewCell {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CarouselCell can be added into new file

Copy link

@ramesh-kuntamala ramesh-kuntamala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@rakutentech-danger-bot
Copy link
Collaborator

rakutentech-danger-bot commented Dec 10, 2024

21 Warnings
⚠️ Big PR
⚠️ This PR does not have any assignees yet
⚠️ Branch name "RMCCX-7619" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>
⚠️ Commit message "chore: fix bitrise failure (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: remove deleted file from xcodeproj (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor tests for campaign dispatcher (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor code and fix alignment (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor code (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: increase test coverage (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: add tests (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix sonar cloud issues (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor code and address review comments (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix github issues (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: change macos version in github workflow" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "fix: bitrise errors (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix sonar cloud error and uitest failure (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix UI tests (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor code to reduce cognitive complexity (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Verb "addres" in the commit message must be in imperative tense
⚠️ Commit message "chore: address review comments (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: Implement UI display with manual scroll for Carousel View (RMCCX-7619)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)

Current coverage for RInAppMessaging.framework is 90.24%

Files changed - -
Router.swift 85.53%
FullView.swift 88.62%
CarouselCell.swift 91.67%
BaseViewPresenter.swift 94.34%
FullViewPresenter.swift 95.85%
CarouselView.swift 97.00%
CampaignDispatcher.swift 97.38%
FullViewModel.swift 100.00%
CampaignDataModels.swift 100.00%
Constants.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

Sources/RInAppMessaging/CampaignDispatcher.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/CampaignDispatcher.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/CampaignDispatcher.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/Views/CarouselView.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/Views/FullView.swift Outdated Show resolved Hide resolved
Tests/Tests/RouterSpec.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/Constants.swift Show resolved Hide resolved
Copy link
Contributor

@Esakkiraja-Pothikannan Esakkiraja-Pothikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the changes in the CampaignDispatcher.swift file are tested ?

Copy link
Contributor

@Esakkiraja-Pothikannan Esakkiraja-Pothikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases for changes in the file CampaignDispatcher.swift

#340 (review)

Sources/RInAppMessaging/CampaignDispatcher.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/Models/CarouselData.swift Outdated Show resolved Hide resolved
Sources/RInAppMessaging/Views/FullView.swift Outdated Show resolved Hide resolved
@SoumenRautray SoumenRautray merged commit ecc5ecc into rakutentech:master Dec 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants