-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Implement UI display with manual scroll for Carousel View (RMCCX-7619) #340
Conversation
} | ||
} | ||
|
||
class CarouselCell: UICollectionViewCell { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CarouselCell can be added into new file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me
Current coverage for RInAppMessaging.framework is
|
Files changed | - | - |
---|---|---|
Router.swift | 85.53% |
✅ |
FullView.swift | 88.62% |
✅ |
CarouselCell.swift | 91.67% |
✅ |
BaseViewPresenter.swift | 94.34% |
✅ |
FullViewPresenter.swift | 95.85% |
✅ |
CarouselView.swift | 97.00% |
✅ |
CampaignDispatcher.swift | 97.38% |
✅ |
FullViewModel.swift | 100.00% |
✅ |
CampaignDataModels.swift | 100.00% |
✅ |
Constants.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How the changes in the CampaignDispatcher.swift
file are tested ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases for changes in the file CampaignDispatcher.swift
Quality Gate passedIssues Measures |
Description
Implemented UI display with manual scroll for Carousel View .
Links
[RMCCX-7619]
Checklist
fastlane ci
without errorsSampleSPM/SampleSPM.xcodeproj
project