Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add production logs and refactor Logger (RMCCX-6877) #326

Closed
wants to merge 1 commit into from
Closed

chore: add production logs and refactor Logger (RMCCX-6877) #326

wants to merge 1 commit into from

Conversation

SoumenRautray
Copy link
Contributor

Description

add production logs to IAM

Links

[RMCCx-6877]

Checklist

  • I have read the contributing guidelines
  • I have added to the changelog
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I ran fastlane ci without errors
  • All project file changes are replicated in SampleSPM/SampleSPM.xcodeproj project

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 23, 2024
View reviewed changes
Sources/RInAppMessaging/Utilities/Logger.swift
import Foundation

extension OSLog {
static let sdk = OSLog(category: "RInAppMessaging SDK")

Check notice

Code scanning / mobsfscan

The App logs information. Sensitive information should never be logged. Note

The App logs information. Sensitive information should never be logged.
@rakutentech-danger-bot
Copy link
Collaborator

4 Warnings
⚠️ This PR does not have any assignees yet
⚠️ Branch name "RMCCX-6877" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>
⚠️ Tests were not updated
⚠️ Commit message "chore: add production logs and refactor Logger (RMCCX-6877)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)

Current coverage for RInAppMessaging.framework is 90.01%

Files changed - -
Logger.swift 73.68% ⚠️
RInAppMessaging.swift 94.22% ✅
HttpRequestable.swift 97.89% ✅
InAppMessagingModule.swift 99.22% ✅
CommonUtility.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maureenorea-clores maureenorea-clores Awaiting requested review from maureenorea-clores maureenorea-clores is a code owner

@Esakkiraja-Pothikannan Esakkiraja-Pothikannan Awaiting requested review from Esakkiraja-Pothikannan Esakkiraja-Pothikannan is a code owner

@anish-munirathinam anish-munirathinam Awaiting requested review from anish-munirathinam anish-munirathinam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoumenRautray @rakutentech-danger-bot