Merge branch 'feature' into RMCCX-7351_click

rakutentech · Sep 21, 2024 · 63ba707 · 63ba707
2 parents c902192 + bbcbc52
commit 63ba707
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,6 @@
 ## Changelog
 
 ### Unreleased
-- Features:
     - Implement clickable image through CustomJson [RMCCX-7233]
 
 ### 8.4.0 (2024-09-17) 

diff --git a/Sources/RInAppMessaging/Views/Presenters/FullViewPresenter.swift b/Sources/RInAppMessaging/Views/Presenters/FullViewPresenter.swift
@@ -125,7 +125,6 @@ internal class FullViewPresenter: BaseViewPresenter, FullViewPresenterType, Erro
         }
         logImpression(type: .clickContent)
         sendImpressions()
-
         UIApplication.shared.open(uriToOpen, options: [:], completionHandler: { [view] success in
             if !success, let view = view {
                 self.showURLError(view: view)

diff --git a/Tests/Tests/ViewPresenterSpec.swift b/Tests/Tests/ViewPresenterSpec.swift
@@ -774,6 +774,7 @@ class ViewPresenterSpec: QuickSpec {
                     expect(view.wasDismissCalled).to(beFalse())
                     expect(impressionService.sentImpressions).to(beNil())
                 }
+
                 it("will do nothing if redirect URL is invalid") {
                     let campaignClickableImage = TestHelpers.generateCampaign(id: "ClickableImage",
                                                                               hasImage: true,
@@ -784,6 +785,7 @@ class ViewPresenterSpec: QuickSpec {
                     expect(view.wasDismissCalled).to(beFalse())
                     expect(impressionService.sentImpressions).to(beNil())
                 }
+
                 it("will do nothing if clickableImage is empty") {
                     let campaignClickableImage = TestHelpers.generateCampaign(id: "ClickableImage",
                                                                               hasImage: true,