fix: revert logger to single parameter (SDKCF-5737)

rakutentech · Aug 4, 2022 · 50b18af · 50b18af
1 parent cdcc521
commit 50b18af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -225,6 +225,9 @@ val retrofit = Retrofit.Builder().build("your_baseUrl", okHttpClient gsonConvert
 
 ## Changelog
 
+### v2.1.1 (2022-08-04)
+* SDKCF-5737: Reverted `Logger` constructor to single parameter.
+
 ### v2.1.0 (2022-08-02)
 * SDKCF-5307: Added version string resource which can be referenced by the name `sdk_utils__version`.
 * SDKCF-4921: Added support for building with Java 11.

diff --git a/sdk-utils/src/main/kotlin/com/rakuten/tech/mobile/sdkutils/logger/Logger.kt b/sdk-utils/src/main/kotlin/com/rakuten/tech/mobile/sdkutils/logger/Logger.kt
@@ -25,18 +25,16 @@ import kotlin.math.min
  *  @param [tag] Optional identifier for the source of a log message. Default value is "".
  */
 @SuppressWarnings("TooManyFunctions", "SpreadOperator")
-open class Logger(
-    private val tag: String = "",
+open class Logger(private val tag: String = "") {
 
     /**
      * The level of the stack trace to be logged.
      * Set by default to 5 (it's the trace level of the running thread when
      * SDKUtils is implemented in an application). If the logger is used in another SDK
      * you may need to upgrade it using `loggerInstance.setDebug()` to display the host SDK's logs.
      */
-    private var stackTraceLevel: Int = 5
-) {
-
+    @SuppressWarnings("MagicNumber")
+    private var stackTraceLevel = 5
     private var isDebug = false
 
     @SuppressWarnings("LongMethod", "ComplexMethod", "NestedBlockDepth")