Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send impression and push primer analytics events (RMCCX-6936, RMCCX-6937) #389

Conversation

maureenorea-clores
Copy link
Collaborator

@maureenorea-clores maureenorea-clores commented Jul 29, 2024

Description

Send events to both app and internal accounts

Links

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
  • I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
  • I tested non-trivial changes on a real device
  • I added ticket/changes in changelog
  • I ran ./gradlew check without errors

@maureenorea-clores maureenorea-clores changed the title feat: send impression and push primer analytics events (RMCCX-6936) feat: send impression and push primer analytics events (RMCCX-6936, RMCCX-6937) Jul 29, 2024
Copy link

@rakutentech-danger-bot
Copy link
Collaborator

3 Warnings
⚠️ Branch name "feat/RMCCX-6936_rmc-rat" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>.
⚠️ PR title "feat: send impression and push primer analytics events (RMCCX-6936, RMCCX-6937)" should append ticket number(s).
⚠️ No coverage data found for com/rakuten/tech/mobile/inappmessaging/runtime/utils/InAppMessagingConstants

JaCoCo Code Coverage 97.7% ✅

Class Covered Meta Status
com/rakuten/tech/mobile/inappmessaging/runtime/manager/PushPrimerTrackerManager 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/manager/AnalyticsManager 83% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/manager/ImpressionManager 88% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/utils/InAppMessagingConstants No coverage data found : -% No coverage data found : -% 🃏
com/rakuten/tech/mobile/inappmessaging/runtime/EventTrackerHelper 87% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/models/appevents/BaseEvent 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/models/appevents/PurchaseSuccessfulEvent 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/models/appevents/CustomEvent 100% 0%

Generated by 🚫 Danger

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores merged commit 391fb13 into rakutentech:master Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants