Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: save user details in sample app cache #372

Conversation

maureenorea-clores
Copy link
Collaborator

Description

  • For testing app relaunches
  • Previously this was implemented in onDestroy but it isn't guaranteed to be called

@maureenorea-clores maureenorea-clores changed the title sample app: save user details to cache improve: save user details in sample app cache Feb 2, 2024
@rakutentech-danger-bot
Copy link
Collaborator

2 Warnings
⚠️ Tests were not updated.
⚠️ PR title "improve: save user details in sample app cache" should append ticket number(s).

JaCoCo Code Coverage 97.6% ✅

Class Covered Meta Status

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores merged commit f0a7339 into rakutentech:master Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants