Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usleep with sleep #906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace usleep with sleep #906

wants to merge 1 commit into from

Conversation

neheb
Copy link

@neheb neheb commented Aug 23, 2019

usleep was deprecated with POSIX 2008 and optionally unavailable with
uClibc-ng.

@neheb
Copy link
Author

neheb commented Aug 23, 2019

Build failure seems unrelated.

@rakshasa
Copy link
Owner

Seems like this should follow the other pull request you made and use c++'s sleep idiom.

@neheb
Copy link
Author

neheb commented Aug 28, 2019

Ehhh it would make the line really long. usleep to sleep is simpler.

@rakshasa
Copy link
Owner

There is the point of consistency, which makes refactoring in the future easier. And the point is to move from C api to standard C++.

@neheb
Copy link
Author

neheb commented Aug 28, 2019

Done.

@rakshasa
Copy link
Owner

rakshasa commented Sep 5, 2019

Sorry, but you should make sure it compiles first.

usleep was deprecated with POSIX 2008 and optionally unavailable with
uClibc-ng.
@neheb
Copy link
Author

neheb commented Sep 5, 2019

Should be fixed now.

@neheb
Copy link
Author

neheb commented Sep 9, 2019

Build failures are unrelated looks like.

@rakshasa
Copy link
Owner

I'll merge this once I've completed some other stuff and have a chance to test it.

Copy link

@h3xx h3xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles for me in GCC 10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants